From 34c240d43a208ef9f3b6f118a536c24d54b3de8d Mon Sep 17 00:00:00 2001
From: Peter Goodhall <peter@magicbug.co.uk>
Date: Wed, 21 May 2025 23:06:59 +0100
Subject: [PATCH] Improve station profile page layout and fix HTML issues

This commit makes two main improvements to the station profile page:

1. UI/Layout improvements:
   - Move the "Create Station Location" button next to the page title
   - Create a flex container for better alignment of title and button
   - Remove unnecessary paragraph tags around the button

2. HTML validation fixes:
   - Add missing quotes around title attributes in buttons
   - Replace incorrect </br> tag with proper <br> tag
   - Fix duplicate closing </td> tag in empty log section
   - Clean up extra whitespace

These changes improve both the visual appearance and HTML validity of the
station profile page.
---
 application/views/station_profile/index.php | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/application/views/station_profile/index.php b/application/views/station_profile/index.php
index c45df598..83899cb7 100644
--- a/application/views/station_profile/index.php
+++ b/application/views/station_profile/index.php
@@ -8,7 +8,10 @@
 		</div>
 	<?php } ?>
 
-<h2><?php echo $page_title; ?></h2>
+<div class="d-flex justify-content-between align-items-center mb-3">
+  <h2><?php echo $page_title; ?></h2>
+  <a href="<?php echo site_url('station/create'); ?>" class="btn btn-primary"><i class="fas fa-plus"></i> <?php echo lang('station_location_create'); ?></a>
+</div>
 
 <div class="card">
   <div class="card-body">
@@ -16,8 +19,6 @@
 	<p class="card-text"><?php echo lang('station_location_header_ln2'); ?></p>
 	<p class="card-text"><?php echo lang('station_location_header_ln3'); ?></p>
 
-	  <p><a href="<?php echo site_url('station/create'); ?>" class="btn btn-primary"><i class="fas fa-plus"></i> <?php echo lang('station_location_create'); ?></a></p>
-
 		<?php if ($stations->num_rows() > 0) { ?>
 
 		<?php if($current_active == 0) { ?>
@@ -28,8 +29,7 @@
 
 		<?php if (($is_there_qsos_with_no_station_id >= 1) && ($is_admin)) { ?>
 			<div class="alert alert-danger" role="alert">
-		  		<span class="badge rounded-pill text-bg-warning"><?php echo lang('general_word_warning'); ?></span> <?php echo lang('station_location_warning_reassign'); ?>
-				</br>
+		  		<span class="badge rounded-pill text-bg-warning"><?php echo lang('general_word_warning'); ?></span> <?php echo lang('station_location_warning_reassign'); ?>				<br>
 				<?php echo lang('station_location_reassign_at'); ?> <a href="<?php echo site_url('maintenance/'); ?>" class="btn btn-warning"><i class="fas fa-sync"></i><?php echo lang('account_word_admin') . "/" . lang('general_word_maintenance'); ?></a>
 			</div>
 		<?php } ?>
@@ -73,17 +73,16 @@
 						<?php if($row->user_id == "") { ?>
 							<a href="<?php echo site_url('station/claim_user')."/".$row->station_id; ?>" class="btn btn-outline-primary btn-sm"><i class="fas fa-user-plus"></i> <?php echo lang('station_location_claim_ownership'); ?></a>
 						<?php } ?>
-						<a href="<?php echo site_url('station/edit')."/".$row->station_id; ?>" title=<?php echo lang('admin_edit'); ?> class="btn btn-outline-primary btn-sm"><i class="fas fa-edit"></i></a>
+						<a href="<?php echo site_url('station/edit')."/".$row->station_id; ?>" title="<?php echo lang('admin_edit'); ?>" class="btn btn-outline-primary btn-sm"><i class="fas fa-edit"></i></a>
 						</td>
 						<td style="text-align: center; vertical-align: middle;">
-						<a href="<?php echo site_url('station/copy')."/".$row->station_id; ?>" title=<?php echo lang('admin_copy'); ?> class="btn btn-outline-primary btn-sm"><i class="fas fa-copy"></i></a>
+						<a href="<?php echo site_url('station/copy')."/".$row->station_id; ?>" title="<?php echo lang('admin_copy'); ?>" class="btn btn-outline-primary btn-sm"><i class="fas fa-copy"></i></a>
 					</td>
-                    <td style="text-align: center; vertical-align: middle;">
-                        <a href="<?php echo site_url('station/deletelog')."/".$row->station_id; ?>" class="btn btn-danger btn-sm" title=<?php echo lang('station_location_emptylog'); ?> onclick="return confirm('<?php echo lang('station_location_confirm_del_qso'); ?>');"><i class="fas fa-trash-alt"></i></a></td>
+                    <td style="text-align: center; vertical-align: middle;">                        <a href="<?php echo site_url('station/deletelog')."/".$row->station_id; ?>" class="btn btn-danger btn-sm" title="<?php echo lang('station_location_emptylog'); ?>" onclick="return confirm('<?php echo lang('station_location_confirm_del_qso'); ?>');"><i class="fas fa-trash-alt"></i></a>
                     </td>
 					<td style="text-align: center; vertical-align: middle;">
 						<?php if($row->station_active != 1) { ?>
-							<a href="<?php echo site_url('station/delete')."/".$row->station_id; ?>" class="btn btn-danger btn-sm" title=<?php echo lang('admin_delete'); ?> onclick="return confirm('<?php echo lang('station_location_confirm_del_stationlocation'); ?> <?php echo $row->station_profile_name; ?> <?php echo lang('station_location_confirm_del_stationlocation_qso'); ?>');"><i class="fas fa-trash-alt"></i></a>
+							<a href="<?php echo site_url('station/delete')."/".$row->station_id; ?>" class="btn btn-danger btn-sm" title="<?php echo lang('admin_delete'); ?>" onclick="return confirm('<?php echo lang('station_location_confirm_del_stationlocation'); ?> <?php echo $row->station_profile_name; ?> <?php echo lang('station_location_confirm_del_stationlocation_qso'); ?>');"><i class="fas fa-trash-alt"></i></a>
 						<?php } ?>
 					</td>
 				</tr>