From 759c7b31f2b7405f848e385486b28486951ebd6d Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Mon, 25 Aug 2025 15:14:21 +0000
Subject: [PATCH] Fix PHP 8.x compatibility issues across the codebase

Co-authored-by: magicbug <84308+magicbug@users.noreply.github.com>
---
 application/views/components/hamsat/table.php |  4 ++--
 application/views/logbookadvanced/index.php   |  4 ++--
 system/libraries/Encryption.php               | 19 +++++++++++++++----
 3 files changed, 19 insertions(+), 8 deletions(-)

diff --git a/application/views/components/hamsat/table.php b/application/views/components/hamsat/table.php
index d46b4b47..4a880d07 100644
--- a/application/views/components/hamsat/table.php
+++ b/application/views/components/hamsat/table.php
@@ -107,8 +107,8 @@
                             ?>
                             <td><span data-bs-toggle="tooltip" title="<?php if ($rove['mhz'] != '') {
                                                                             printf("%.3f", $rove['mhz']);
-                                                                            echo " " . $direction ?? '';
-                                                                        } ?>"><?= $rove['satellite']['name'] ?></span></td>
+                                                                            echo " " . ($direction ?? '');
+                                                                        } ?>"><?php echo $rove['satellite']['name']; ?></span></td>
                             <td><span title="<?php echo $rove['mode']; ?>" class="badge <?php echo $modeclass; ?>"><?php echo $rove['mode']; ?></span></td>
                             <td>
 
diff --git a/application/views/logbookadvanced/index.php b/application/views/logbookadvanced/index.php
index 35d5e367..7cfd0345 100644
--- a/application/views/logbookadvanced/index.php
+++ b/application/views/logbookadvanced/index.php
@@ -21,8 +21,8 @@ if (!isset($options->operator)) {
 ?>
 </script>
 <script>
-    const CSRF_NAME = '<?= $this->security->get_csrf_token_name(); ?>';
-    const CSRF_HASH = '<?= $this->security->get_csrf_hash(); ?>';
+    const CSRF_NAME = '<?php echo $this->security->get_csrf_token_name(); ?>';
+    const CSRF_HASH = '<?php echo $this->security->get_csrf_hash(); ?>';
 </script>
 <style>
 /*Legend specific*/
diff --git a/system/libraries/Encryption.php b/system/libraries/Encryption.php
index b11588af..60518ec8 100644
--- a/system/libraries/Encryption.php
+++ b/system/libraries/Encryption.php
@@ -152,7 +152,7 @@ class CI_Encryption {
 	public function __construct(array $params = array())
 	{
 		$this->_drivers = array(
-			'mcrypt'  => defined('MCRYPT_DEV_URANDOM'),
+			'mcrypt'  => defined('MCRYPT_DEV_URANDOM') && function_exists('mcrypt_encrypt'),
 			'openssl' => extension_loaded('openssl')
 		);
 
@@ -203,9 +203,20 @@ class CI_Encryption {
 
 		if (empty($this->_driver))
 		{
-			$this->_driver = ($this->_drivers['openssl'] === TRUE)
-				? 'openssl'
-				: 'mcrypt';
+			// Prefer OpenSSL on modern PHP versions where mcrypt is not available
+			if ($this->_drivers['openssl'] === TRUE)
+			{
+				$this->_driver = 'openssl';
+			}
+			elseif ($this->_drivers['mcrypt'] === TRUE)
+			{
+				$this->_driver = 'mcrypt';
+			}
+			else
+			{
+				// This shouldn't happen as we check both drivers in constructor
+				show_error('Encryption: No available encryption driver found.');
+			}
 
 			log_message('debug', "Encryption: Auto-configured driver '".$this->_driver."'.");
 		}