Fix PHP 8.x compatibility issues across the codebase

Co-authored-by: magicbug <84308+magicbug@users.noreply.github.com>

README.md

@@ -13,7 +13,7 @@ Website: [http://www.cloudlog.co.uk](http://www.cloudlog.co.uk)
 
 - Linux based Operating System
 - Apache (Nginx should work)
-- PHP Version 7.4 (PHP 8.2 works)
+- PHP Version 7.4 or higher (PHP 8.4 supported)
 - MySQL (MySQL 5.7 or higher)
 
 Notes

application/views/components/hamsat/table.php

@@ -107,8 +107,8 @@
                             ?>
                             <td><span data-bs-toggle="tooltip" title="<?php if ($rove['mhz'] != '') {
                                                                             printf("%.3f", $rove['mhz']);
-                                                                            echo " " . $direction ?? '';
+                                                                            echo " " . ($direction ?? '');
-                                                                        } ?>"><?= $rove['satellite']['name'] ?></span></td>
+                                                                        } ?>"><?php echo $rove['satellite']['name']; ?></span></td>
                             <td><span title="<?php echo $rove['mode']; ?>" class="badge <?php echo $modeclass; ?>"><?php echo $rove['mode']; ?></span></td>
                             <td>
 

application/views/dashboard/index.php

@@ -160,7 +160,7 @@ function echoQrbCalcLink($mygrid, $grid, $vucc)
 <div class="container dashboard">
 	<?php if (($this->config->item('use_auth') && ($this->session->userdata('user_type') >= 2)) || $this->config->item('use_auth') === FALSE) { ?>
 
-		<?php if (version_compare(PHP_VERSION, '7.4.0') <= 0) { ?>
+		<?php if (version_compare(PHP_VERSION, '8.0.0') < 0) { ?>
 			<div class="alert alert-danger" role="alert">
 				<?php echo lang('dashboard_php_version_warning') . ' ' . PHP_VERSION . '.'; ?>
 			</div>

application/views/logbookadvanced/index.php

@@ -21,8 +21,8 @@ if (!isset($options->operator)) {
 ?>
 </script>
 <script>
-    const CSRF_NAME = '<?= $this->security->get_csrf_token_name(); ?>';
+    const CSRF_NAME = '<?php echo $this->security->get_csrf_token_name(); ?>';
-    const CSRF_HASH = '<?= $this->security->get_csrf_hash(); ?>';
+    const CSRF_HASH = '<?php echo $this->security->get_csrf_hash(); ?>';
 </script>
 <style>
 /*Legend specific*/

index.php

@@ -74,7 +74,7 @@ switch (ENVIRONMENT)
 	case 'testing':
 	case 'production':
 		ini_set('display_errors', 0);
-		if (version_compare(PHP_VERSION, '5.3', '>='))
+		if (version_compare(PHP_VERSION, '7.0', '>='))
 		{
 			error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED & ~E_STRICT & ~E_USER_NOTICE & ~E_USER_DEPRECATED);
 		}

system/libraries/Encryption.php

@@ -152,7 +152,7 @@ class CI_Encryption {
 	public function __construct(array $params = array())
 	{
 		$this->_drivers = array(
-			'mcrypt'  => defined('MCRYPT_DEV_URANDOM'),
+			'mcrypt'  => defined('MCRYPT_DEV_URANDOM') && function_exists('mcrypt_encrypt'),
 			'openssl' => extension_loaded('openssl')
 		);
 
@@ -203,9 +203,20 @@ class CI_Encryption {
 
 		if (empty($this->_driver))
 		{
-			$this->_driver = ($this->_drivers['openssl'] === TRUE)
+			// Prefer OpenSSL on modern PHP versions where mcrypt is not available
-				? 'openssl'
+			if ($this->_drivers['openssl'] === TRUE)
-				: 'mcrypt';
+			{
+				$this->_driver = 'openssl';
+			}
+			elseif ($this->_drivers['mcrypt'] === TRUE)
+			{
+				$this->_driver = 'mcrypt';
+			}
+			else
+			{
+				// This shouldn't happen as we check both drivers in constructor
+				show_error('Encryption: No available encryption driver found.');
+			}
 
 			log_message('debug', "Encryption: Auto-configured driver '".$this->_driver."'.");
 		}